Skip to content

Firestore: use correct environment variable to guard the 'system' part. - #7912

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:firestore-nox-correct-systest-envvar
May 17, 2019
Merged

tseaver merged 2 commits into
googleapis:masterfrom
tseaver:firestore-nox-correct-systest-envvar

Conversation

@tseaver

@tseaver tseaver commented May 9, 2019

Copy link
Copy Markdown
Contributor

Firestore's system tests use a different environment variable (because firestore vs. datastore hysterical raisins).

@tseaver tseaver added testing api: firestore Issues related to the Firestore API. labels May 9, 2019
@tseaver
tseaver requested a review from crwilcox May 9, 2019 17:12
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 9, 2019
@tseaver tseaver added the codegen label May 9, 2019
Comment thread firestore/noxfile.py Resolved
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 16, 2019
@tseaver

tseaver commented May 16, 2019

Copy link
Copy Markdown
Contributor Author

@busunkim96 I fixed the docs session issue by regenerating with an up-to-date version of sythtool. PTAL.

@tseaver
tseaver merged commit c97bef4 into googleapis:master May 17, 2019
@tseaver
tseaver deleted the firestore-nox-correct-systest-envvar branch May 17, 2019 19:49
parthea pushed a commit that referenced this pull request Nov 24, 2025
…t. (#7912)

* Use the correct environment variable to guard the 'system' part.

* Restore 'docs' session via synth.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. codegen 🚨 This issue needs some love. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants